defer release resouce

bbclearn/bbc.go

@@ -65,6 +65,7 @@ func fetch(u string) (r rss2.Item) {
 		return
 	}
 	dom, err := goquery.NewDocumentFromReader(res.Body)
+	defer res.Body.Close()
 	if err != nil {
 		return
 	}
@@ -104,6 +105,7 @@ func downAndSendMail(doc *goquery.Document, title string) {
 	if err != nil {
 		return
 	}
+	var fn []func()
 	for _, ss := range []string{".bbcle-download-extension-pdf", ".bbcle-download-extension-mp3"} {
 		uu, ok := doc.Find(ss).Attr("href")
 		if ok {
@@ -116,6 +118,10 @@ func downAndSendMail(doc *goquery.Document, title string) {
 			if err != nil {
 				continue
 			}
+			fn = append(fn, func() {
+				response.Body.Close()
+				file.Close()
+			})
 			_, err = io.Copy(file, response.Body)
 			if err != nil {
 				continue
@@ -123,6 +129,11 @@ func downAndSendMail(doc *goquery.Document, title string) {
 			mm.f = append(mm.f, name)
 		}
 	}
+	defer func() {
+		for _, f := range fn {
+			f()
+		}
+	}()
 	if len(mm.f) < 1 {
 		return
 	}

mail/mail.go

@@ -38,14 +38,6 @@ func SendMail(subject string, content string, files ...string) error {
 	}
 
 	cmd := exec.Command(cm, v...)
-	file, err := os.OpenFile("run.sh", os.O_CREATE|os.O_APPEND, 0755)
-	if err != nil {
-		return err
-	}
-	_, err = file.WriteString(cmd.String())
-	if err != nil {
-		return err
-	}
 	output, err := cmd.CombinedOutput()
 	log.Println(string(output))
 	return err